Fixes version check for ActiveRecord adapter introduced in #478 #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ActiveRecord 7.2 the `clear_active_connections` was (re)moved to the `connection_handler` property.
Update ActiveRecord adapter w/ support for Rails 7.2+
Fix version check in ActiveRecord adapter: the "target" version for comparison needs to be a string. Fixes: ArgumentError: comparison of Gem::Version with 7.2 failed
|
@jkeen I have no idea how this passed the tests ... |
Fix linting complaint for String constant.
|
@richmolj @wadetandy @jkeen any maintainers who can review, merge, and release a new version? please ... |
|
@mihaimuntenas Missed the notification on this, sorry for delay! Also have no idea how that passed tests, but thanks for catching it and supplying a fix. |
|
@jkeen thanks a lot! If you can also do a . release would be great. |
|
Ack, yeah that's an intermittent error, just reran that test—releasing now. |
|
🎉 This PR is included in version 1.7.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes version check for ActiveRecord version, introduced in #478, that's causing an ArgumentError, as the target version for the comparison is expected to be a String not a Number.
@jkeen