Skip to content

Test fixes #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025
Merged

Test fixes #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12784c3
Require logger to avoid error
jkeen Mar 14, 2025
51e004e
fix: change class attribute behavior on endpoint to work in ruby 3.2+
jkeen Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/graphiti/resource/links.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,17 @@ module Overrides
def endpoint
if (endpoint = super)
endpoint
else
elsif !@__skip_inference
self.endpoint = infer_endpoint
end
end

def endpoint=(value)
# changes introduced in Ruby 3.2 and above require some extra hoops
# to allow .endpoint = nil to work properly
@__skip_inference = value.blank?
super
end
end

included do
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Dir[File.dirname(__FILE__) + "/support/**/*.rb"].sort.each { |f| require f }
require "pry"

require "logger"
require "active_model"
require "graphiti_spec_helpers/rspec"
require "graphiti"
Expand Down