curation: add a withdrawal fee #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davekay100
approved these changes
May 27, 2020
| await this.curation.stake(this.subgraphId, this.curatorTokens, { from: curator }) | ||
| // Set new value | ||
| await this.curation.setWithdrawalFeePercentage(0, { from: governor }) | ||
| await this.curation.setWithdrawalFeePercentage(1, { from: governor }) |
There was a problem hiding this comment.
why are we setting it three times?
There was a problem hiding this comment.
It's wrong to set it three times, I will delete one of those.
It should set two times, one to check that zero is allowed and other one to a non-zero number.
There was a problem hiding this comment.
I will address this fix in the PR that uses Typescript
abarmat
force-pushed
the
ariel/curation-withdrawal-fee
branch
from
50978a7 to
633631e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
withdrawalFeePercentageparameter only set by governor.