Skip to content

fix: ensure contracts are only initialized once (C4 M-149) #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

pcarranzav
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 91.58% // Head: 91.58% // No change to project coverage 👍

Coverage data is based on head (85312a0) compared to base (bcb4802).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           pcv/c4-699-m201-l2counterpart-set     #741   +/-   ##
==================================================================
  Coverage                              91.58%   91.58%           
==================================================================
  Files                                     42       42           
  Lines                                   1997     1997           
  Branches                                 357      357           
==================================================================
  Hits                                    1829     1829           
  Misses                                   168      168           
Flag Coverage Δ
unittests 91.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/gateway/BridgeEscrow.sol 100.00% <100.00%> (ø)
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/token/L2GraphToken.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav force-pushed the pcv/c4-699-m201-l2counterpart-set branch from 86f99ab to bcb4802 Compare October 21, 2022 20:06
@pcarranzav pcarranzav force-pushed the pcv/c4-699-m149-initializers branch from 51e06bb to 85312a0 Compare October 21, 2022 20:07
@pcarranzav pcarranzav requested review from abarmat and tmigone October 24, 2022 22:00
Base automatically changed from pcv/c4-699-m201-l2counterpart-set to pcv/l2-bridge November 23, 2022 14:23
@pcarranzav pcarranzav merged commit 85312a0 into pcv/l2-bridge Nov 23, 2022
@pcarranzav pcarranzav deleted the pcv/c4-699-m149-initializers branch November 23, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants