Extract Iron + Rocket #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
theduke
commented
Aug 6, 2017
theduke
commented
Rocket's traits have changed in version 0.3.0, this commit adjusts the existing implementation to be compatible with the latest version of the traits.
This split still requires some work as the tests currently fail. This is caused by the fact that some previously private modules can't be accessed anymore, and that Rocket changet it's testing framework.
* Added juniper_iron crate * Fixed up juniper_rocket crate * Updated juniper/Cargo.toml * Updated docs (readme, module docs) * Export http integrator tests with export-test-schema feature * Update CI tests (Use cargo-make ) * Format parts of the code base
Due to cargo-make bug...
Rocket only works on nightly + Not done on appveyor anyway
theduke
force-pushed
the
extract-iron
branch
3 times, most recently
from
7d04dd0 to
08e035d
Compare
Rocket is only supported on nightly, and rocket depends on Ring, which does not support the gcc toolchain on Windows.
|
The tests have succeded on my fork! To avoid waiting for hours until AppVeyor gets it's ass moving, I'm merging now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.