Publish as ESM only #4385
Closed
Publish as ESM only #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
force-pushed
the
esm-only
branch
5 times, most recently
from
8fc1d0a to
09613a3
Compare
yaacovCR
reviewed
May 26, 2025
benjie
reviewed
May 30, 2025
Co-authored-by: Benjie <[email protected]>
yaacovCR
reviewed
Jun 4, 2025
| @@ -26,7 +26,7 @@ | |||
| "graphql-js" | |||
| ], | |||
| "engines": { | |||
| "node": "^16.19.0 || ^18.14.0 || >=19.7.0" | |||
| "node": ">=20.19.0 || >=22.12.0 || >=23.0.0 || >=24.0.0" | |||
There was a problem hiding this comment.
Suggested change
| "node": ">=20.19.0 || >=22.12.0 || >=23.0.0 || >=24.0.0" | |
| "node": "^20.19.0 || ^22.12.0 || >=23.0.0" |
I believe the >= meaning anything greater than, so 22.11.0 incorrectly passes for me with existing specifiers.
For same reason we only need one >=, as >=23.0.0 implies >=24.0.0
yaacovCR
reviewed
Jun 4, 2025
| @@ -30,7 +30,7 @@ | |||
| "typescript-eslint": "^8.17.0" | |||
| }, | |||
| "engines": { | |||
| "node": "^16.19.0 || ^18.14.0 || >=19.7.0" | |||
| "node": ">=19.7.0 || >=20.0.0 || >=22.0.0" | |||
There was a problem hiding this comment.
Suggested change
| "node": ">=19.7.0 || >=20.0.0 || >=22.0.0" | |
| "node": "^20.19.0 || ^22.12.0 || >=23.0.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dual package hazard and a lot of concerns we had for the
instanceofchecks going forward. This change will make it safer to remove the dev-check and just be ESM only, this change is motivated by Node 18 being dropped and Node 20 and onwards supportingrequire(esm)