618 check systems test rewrite

[dan-mm]

One thing I noticed while doing this is the following: here is the check_one_psu_provider function that is called in systems_check.py:

def check_one_psu_provider():
    metric_providers = utils.get_metric_providers(GlobalConfig().config).keys()
    energy_machine_providers = [provider for provider in metric_providers if ".energy" in provider and ".machine" in provider]
    return len(energy_machine_providers) <= 1

it checks for keys that have .energy and .machine in the key and determines those as psu providers. Why do we not check for keys that have .psu instead?

[github-actions]

Old Energy Estimation

Eco-CI Output:

Label	🖥 avg. CPU utilization [%]	🔋 Total Energy [Joules]	🔌 avg. Power [Watts]	Duration [Seconds]
Total Run	20.6496	1021.84	3.37241	310
Measurement #1	20.9226	1021.84	3.37241	304

📈 Energy graph:

 
 7.77 ┤                                                        ╭╮
 7.17 ┤                                      ╭╮                ││
 6.57 ┤                                      ││                ││
 5.97 ┤                                     ╭╯│           ╭─╮  │╰╮╭╮
 5.37 ┤                                     │ │          ╭╯ ╰╮ │ ╰╯│
 4.77 ┤                                     │ ╰─╮╭─╮╭╮   │   │ │   │              ╭╮
 4.17 ┤     ╭─╮    ╭─╮  ╭╮╭╮ ╭──╮    ╭─╮    │   ╰╯ ╰╯│   │   ╰╮│   │        ╭╮╭╮  ││ ╭─╮ ╭╮╭╮                        ╭╮ ╭────╮                              ╭╮ ╭╮     ╭╮               ╭╮       ╭╮  ╭╮     ╭╮                              ╭╮        ╭╮                  ╭╮        ╭╮ ╭╮╭╮                          ╭
 3.57 ┤    ╭╯ ╰────╯ ╰──╯╰╯╰─╯  ╰────╯ ╰╮   │        ╰╮ ╭╯    ╰╯   │       ╭╯╰╯╰─╮││╭╯ ╰─╯╰╯╰────────────────────────╯╰─╯    ╰──────╮                    ╭──╯╰─╯╰──╮╭─╯╰───────────────╯╰───────╯╰──╯╰─────╯╰╮          ╭╮         ╭╮ ╭────╯╰───────╮│╰──────────────────╯╰────────╯╰─╯╰╯╰─╮        ╭─╮         ╭╮ ╭╯
 2.97 ┤    │                            │╭──╯         │ │          │       │     ╰╯╰╯                                               │                    │         ││                                        ╰╮        ╭╯│         │╰╮│             ╰╯                                     │        │ │         ││ │
 2.37 ┤    │                            ││            ╰╮│          │       │                                                        │                   ╭╯         ╰╯                                         │       ╭╯ ╰─╮       │ ││                                                    │       ╭╯ ╰╮        ││ │
 1.77 ┼────╯                            ╰╯             ╰╯          ╰───────╯                                                        ╰───────────────────╯                                                     ╰───────╯    ╰───────╯ ╰╯                                                    ╰───────╯   ╰────────╯╰─╯
                                                                                                                                                       Watts over time

[ArneTR]

One thing I noticed while doing this is the following: here is the check_one_psu_provider function that is called in systems_check.py:

def check_one_psu_provider():
    metric_providers = utils.get_metric_providers(GlobalConfig().config).keys()
    energy_machine_providers = [provider for provider in metric_providers if ".energy" in provider and ".machine" in provider]
    return len(energy_machine_providers) <= 1

it checks for keys that have .energy and .machine in the key and determines those as psu providers. Why do we not check for keys that have .psu instead?

The naming of the test is misleading. What we actually want to check is that we do not have two providers that provider energy and scope machine. Where the value is coming from is irrelevant. It can be a PSU, but also a PDU would be fine.

Please change the name of the test and maybe also the error message if that claims PSU is the problem rather than energy_ machine_ . Then fine to merge

[dan-mm]

done - will merge after I see tests pass

[github-actions]

Eco-CI Output:

Label	🖥 avg. CPU utilization [%]	🔋 Total Energy [Joules]	🔌 avg. Power [Watts]	Duration [Seconds]
Total Run	19.7835	1296.85	3.31676	398
Measurement #1	20.032	1296.85	3.31676	392

📈 Energy graph:

 
 7.74 ┤                                                                                     ╭╮                             ╭╮
 7.14 ┤                                                                                     ││                             ││
 6.55 ┤                                                                                     │╰╮                       ╭╮   ││
 5.95 ┤                                                                                     │ │                       ││   ││╭╮
 5.35 ┤              ╭╮                                                       ╭╮            │ │                      ╭╯╰╮ ╭╯│││
 4.75 ┤              ││                                                       ││            │ │  ╭─╮╭╮              ╭╯  ╰╮│ ╰╯│
 4.16 ┤             ╭╯╰─╮  ╭───╮ ╭╮    ╭╮   ╭╮╭─╮    ╭─╮                      │╰╮          ╭╯ ╰──╯ ╰╯╰╮             │    ╰╯   │         ╭╮╭╮  ╭╮  ╭─╮ ╭╮╭╮    ╭╮                  ╭╮ ╭─────╮                              ╭╮ ╭╮     ╭╮         ╭╮    ╭╮  ╭─╮  ╭╮  ╭╮     ╭╮                                   ╭╮ ╭╮   ╭╮  ╭╮                                  ╭╮                                            ╭
 3.56 ┤      ╭╮ ╭╮ ╭╯   ╰──╯   ╰─╯╰──╮╭╯╰───╯╰╯ │    │ ╰──────────────────────╯ ╰──────────╯          │             │         ╰╮       ╭╯││╰──╯╰╮╭╯ ╰─╯╰╯╰────╯╰─────────────────╮│╰─╯     ╰────╮                      ╭──╯╰─╯╰──╮╭─╯╰─────────╯╰────╯╰──╯ ╰──╯╰──╯╰─────╯╰─╮         ╭─╮         ╭╮ ╭───╮╭───╯╰─╯╰───╯╰╮ │╰────╮╭─────╮╭─╮╭╮╭─╮╭───╮╭──────╮╭╯╰──╮╭────╮╭───────╮          ╭╮         ╭─╮╭─╯
 2.96 ┤      ││ │╰─╯                 ╰╯         ╰╮╭╮ │                                                │             │          │       │ ││     ╰╯                               ││             ╰╮                     │         ││                                         │         │ │         ││ │   ││             │ │     ╰╯     ╰╯ ││╰╯ ││   ╰╯      ││    ││    ││       ╰╮         ││         │ ││
 2.37 ┤      ││ │                                ╰╯│ │                                                │     ╭╮      │          │       │ ╰╯                                      ││              ╰─╮                  ╭╯         ╰╯                                         │         │ ╰─╮       │╰╮│   ╰╯             │ │               ╰╯   ╰╯           ╰╯    ╰╯    ││        │       ╭╮│╰─╮       │ ││
 1.77 ┼──────╯╰─╯                                  ╰─╯                                                ╰─────╯╰──────╯          ╰───────╯                                         ╰╯                ╰──────────────────╯                                                     ╰─────────╯   ╰───────╯ ╰╯                  ╰─╯                                             ╰╯        ╰───────╯╰╯  ╰───────╯ ╰╯
                                                                                                                                                                                                   Watts over time