xds: Expose filter names to filter instances #11971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support gRFC A83 xDS GCP Authentication Filter: > Otherwise, the filter will look in the CDS resource's metadata for a > key corresponding to the filter's instance name.
shivaspeaks
approved these changes
Mar 21, 2025
| @@ -99,7 +99,7 @@ public boolean isClientFilter() { | |||
| } | |||
|
|
|||
| @Override | |||
| public FaultFilter newInstance() { | |||
| public FaultFilter newInstance(String name) { | |||
There was a problem hiding this comment.
Right. We are not using name here but just to follow the interface we are doing this. I have ditto commit in local.. :)
|
Merging it now to unblock further work on GCPAuthenticationFilter. |
Sangamesh1997
pushed a commit
to Sangamesh1997/grpc-java
that referenced
this pull request
Apr 3, 2025
This is to support gRFC A83 xDS GCP Authentication Filter: > Otherwise, the filter will look in the CDS resource's metadata for a > key corresponding to the filter's instance name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support gRFC A83 xDS GCP Authentication Filter:
CC @sergiitk, @kannanjgithub, @larry-safran