Skip to content

xds: remove the env var GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2021
Merged

xds: remove the env var GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API #7914

merged 1 commit into from
Feb 23, 2021

Conversation

sanjaypujare
Copy link
Contributor

remove dependency on the env var GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API so the change in grpc/grpc#25529 wouldn't be needed.

sergiitk
sergiitk approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanjaypujare sanjaypujare enabled auto-merge (squash) February 23, 2021 19:14
auto-merge was automatically disabled February 23, 2021 19:15

Pull request was closed

@sanjaypujare sanjaypujare reopened this Feb 23, 2021
@sanjaypujare sanjaypujare merged commit bfc67bf into grpc:master Feb 23, 2021
@sanjaypujare sanjaypujare deleted the remove-new-server-api-envvar branch February 23, 2021 19:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@dapengzhang0 dapengzhang0 Awaiting requested review from dapengzhang0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjaypujare @sergiitk