[CloudRun to CloudRun]: Parse stats_port arg from --client_port #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannanjgithub
approved these changes
May 23, 2025
sergiitk
approved these changes
May 28, 2025
sergiitk
changed the title
sergiitk
reviewed
May 28, 2025
| @@ -126,7 +129,7 @@ def deploy_service( | |||
| mesh_name: str, | |||
| server_target: str, | |||
| *, | |||
| test_port: int = DEFAULT_CLIENT_TEST_PORT, | |||
| stats_port: int, | |||
There was a problem hiding this comment.
nit: Move * just below self to require all args to be specified as kwargs explicitly. That's already the case, but * doesn't really make sense in between server_target and stats_port.
There was a problem hiding this comment.
Before this PR it kinda did because test_port had a default value. Though the rule of thumb is to require everything to be a kwarg in a method with a lot of args that aren't intuitive when specified positionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.