feat: re-export setZXingModuleOverrides #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-qrcode-reader ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sec-ant
reviewed
Aug 7, 2023
src/index.ts
Outdated
| @@ -4,6 +4,8 @@ import QrcodeStream from './components/QrcodeStream.vue' | |||
| import QrcodeCapture from './components/QrcodeCapture.vue' | |||
| import QrcodeDropZone from './components/QrcodeDropZone.vue' | |||
|
|
|||
| import { setZXingModuleOverrides } from '@sec-ant/barcode-detector' | |||
There was a problem hiding this comment.
This import is a combination of pure and side-effects, so it can potentially pollute globalThis unintendedly. If only pure module is needed, as shown in the changes of scanner.ts, I suggest changing the import path here to @sec-ant/barcode-detector/pure, too :)
There was a problem hiding this comment.
Ah yes, thanks. I don't know, here I did it right
gruhn
force-pushed
the
reexport-zxing-module-overrides
branch
from
32f429b to
12e544c
Compare
The BarcodeDetector polyfill fetches a WASM file at runtime from a CDN. That's a problem for offline applications or applications that run in a network with strict CSP policy. As a workaround the polyfill exports a function to configure the WASM file URL. So we re-export the function here. Also, by default the BarcodeDetector polyfill installs itself by setting `globalThis.BarcodeDetector` but only if there is no native support. This is likely not SSR compatible. Also, native support `BarcodeDetector` is inconsistent. For example, Chrome on MacOS does support `BarcodeDetector` but does not support `Blob` inputs, violating the specification. To have a more consistent support we simply always use the polyfill on all platforms. That likely comes as at a performance cost in raw scanning speed on supporting platforms but the download penalty is paid either way. See #354 #353
gruhn
force-pushed
the
reexport-zxing-module-overrides
branch
from
12e544c to
099a8d9
Compare
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BarcodeDetector polyfill fetches a WASM file at runtime from a CDN. That's a problem for offline applications or applications that run in a network with strict CSP policy. As a workaround the polyfill exports a function to configure the WASM file URL. So we re-export the function here.
Also, by default the BarcodeDetector polyfill installs itself by setting
globalThis.BarcodeDetectorbut only if there is no native support. This is likely not SSR compatible. Also, native supportBarcodeDetectoris inconsistent. For example, Chrome on MacOS does supportBarcodeDetectorbut does not supportBlobinputs, violating the specification. To have a more consistent support we simply always use the polyfill on all platforms. That likely comes as at a performance cost in raw scanning speed on supporting platforms but the download penalty is paid either way.TODO
maybe create dedicated demoSee #354 #353