Fix choice cards when same product listed twice #13984
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +83 B (+0.01%) Total Size: 1.04 MB ℹ️ View Unchanged
|
tomrf1
changed the title
github-actions
bot
removed
the
run_chromatic
tomrf1
commented
May 21, 2025
| @@ -163,10 +163,14 @@ export const ThreeTierChoiceCards = ({ | |||
| ({ product, label, benefitsLabel, benefits, pill }) => { | |||
| const { supportTier } = product; | |||
|
|
|||
| const selected = | |||
| selectedProduct.supportTier === supportTier; | |||
| const selected = selectedProduct === product; | |||
There was a problem hiding this comment.
this means we compare both the supportTier and ratePlan
There was a problem hiding this comment.
though I've realised this doesn't always work as it's comparing object references! Fix incoming
github-actions
bot
removed
the
run_chromatic
sookburt
approved these changes
May 21, 2025
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's technically possible for the epic/banner choice cards to have the same product listed more than once, for different rate plans. If this happens, the component does not distinguish between them and the input ids are the same. This is an issue because:
This PR fixes the product comparison logic, and adds the rate plan to the input ids.
Before:
After:
