Add MastHead to the GalleryLayout #13988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
marjisound
changed the title
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Closed
JamieB-gu
approved these changes
May 22, 2025
Comment on lines
+44
to
+45
| hasPageSkin={false} | ||
| hasPageSkinContentSelfConstrain={false} |
There was a problem hiding this comment.
Will these always be false? Do they rely on commercial data @arelra ?
There was a problem hiding this comment.
For a GalleryLayout these will always be false as we only apply page skins to network fronts.
hasPageSkin comes from the config in Frontend payload which in turn is populated by the commercial DFP jobs that allow Frontend match the requested page to an 'active' page skin.
hasPageSkinContentSelfConstrain is an option to control whether the container should be full width but the content should still constrain to a page skin width.
cc @Amouzle
arelra
approved these changes
May 27, 2025
Comment on lines
+44
to
+45
| hasPageSkin={false} | ||
| hasPageSkinContentSelfConstrain={false} |
There was a problem hiding this comment.
For a GalleryLayout these will always be false as we only apply page skins to network fronts.
hasPageSkin comes from the config in Frontend payload which in turn is populated by the commercial DFP jobs that allow Frontend match the requested page to an 'active' page skin.
hasPageSkinContentSelfConstrain is an option to control whether the container should be full width but the content should still constrain to a page skin width.
cc @Amouzle
|
Seen on PROD (merged by @marjisound 13 minutes and 46 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adding MastHead to the GalleryLayout