-
Notifications
You must be signed in to change notification settings - Fork 30
Initial reporting page for new A/B test POC #13994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
// See https://svelte.dev/docs/kit/types#app.d.ts | ||
// for information about these interfaces | ||
declare global { | ||
namespace App { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file necessary? Is this a placeholder for future types/interfaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the Sveltekit boilerplate, I believe it is required but will be experimenting with removing more of this as I finalise the build process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of SVG in this component ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clear and neat! Love the use of svg
What does this change?
This adds a simple Svelte-based UI reporting on current A/B test data, intended to be built and deployed as a static page when tests are updated. The build process is to follow in a subsequent PR.
Why?
We have a page in the Frontend admin tool that currently serves this purpose, and which will need to be replaced after migration to the new testing framework. A static HTML page is the simplest replacement, and can be stored in S3 and then served from frontend with little to no practical change for the end user.
This is a very rough first-pass on the UI itself, intended for future improvement and iteration.
Screenshots
Full page, with current demo test data
Hover on audience segment bars