Migrate to v2 of the AWS Java SDK for S3 #27969
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
aws-sdk-v2-s3
branch
5 times, most recently
from
00d1172 to
6cb6fa5
Compare
The first part of the S3 migration. Panda settings require an instance of an `S3BucketLoader`. Panda comes with a default implementation for v1, but not v2, so this change creates one. This first requires a synchronous S3 client, which has been added to the `AWSv2` object alongside the existing asynchronous S3 client. Creating it here, rather than in the controller as before, allows it to be used more widely. Then the `getObject` method can be applied, with a `ResponseTransformer` to retrieve the "content" of the response, i.e. the object itself. We're removing `S3Client` as it became unused with #27391 Co-authored-by: Roberto Tyley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partial, it only updates one usage of S3. Before this can be merged all usages should be updated, so opening as draft for now.
Paired with @rtyley
Changes so far
Panda
Panda settings require an instance of an
S3BucketLoader. Panda comes with a default implementation for v1, but not v2, so this change creates one.This first requires a synchronous S3 client, which has been added to the
AWSv2object alongside the existing asynchronous S3 client. Creating it here, rather than in the controller as before, allows it to be used more widely.Then the
getObjectmethod can be applied, with aResponseTransformerto retrieve the "content" of the response, i.e. the object itself.