Skip to content

Fix Turbo(links) integration #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Nov 8, 2021
Merged

Fix Turbo(links) integration #1985

merged 0 commits into from
Nov 8, 2021

Conversation

cjdenio
Copy link
Member

@cjdenio cjdenio commented Nov 7, 2021

This PR fixes the currently-broken Turbolinks integration (breakage caused by this line) and replaces it with Turbo, Turbolinks's successor.

also see reactjs/react-rails#1103 (comment)

@maxwofford maxwofford temporarily deployed to bank--pr-1985 November 7, 2021 20:10 Inactive
@maxwofford
Copy link
Member

@cjdenio Excited for this! Just assign me as a reviewer once it's ready to check out

@cjdenio cjdenio requested a review from maxwofford November 8, 2021 14:32
Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get past the signin step. Try it out on the preview deploy.

@cjdenio
Copy link
Member Author

cjdenio commented Nov 8, 2021

@maxwofford should be all set now (hotwired/turbo-rails#12 (comment))

@maxwofford
Copy link
Member

Screenrecording of me testing: https://youtu.be/e7_WBQwuLKI

@cjdenio
Copy link
Member Author

cjdenio commented Nov 8, 2021

Hmm, I'm pretty sure this is just Heroku's staging environment being oddly slow.

Turbo actually doesn't apply to certain pages with <% include_modals %> at the top; you'll notice here that the browser's just performing an ordinary page change.

Also, Turbo has its own cache that makes most route changes instantaneous; try switching between "Settings" and "Documentation" (also using the browser back/forward buttons) and it should be very fast.

Copy link
Member

@maxwofford maxwofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Let's go for it and see how it goes. Can you please rebase+merge? Please post in #bank-team once merged letting them know a large change in page loading has been merged and if they run into any issues of slower loading/links acting weird to post it immediately with you tagged.

@maxwofford maxwofford temporarily deployed to bank--pr-1985 November 8, 2021 21:55 Inactive
@cjdenio
Copy link
Member Author

cjdenio commented Nov 8, 2021

Awesome! I'm not in #bank-team, so maybe you could merge + post?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants