Skip to content

ember-intl integration #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented May 14, 2025

📌 Summary

If merged, this PR enables ember-intl for the components package and translates some of the bare strings. It also sets up linting rules preventing the usage of bare strings.

Details

  • Adds ember-intl dependency to both the showcase and components workspaces.
  • Translated all text nodes in the components dir in a single en-us.yaml file
  • Translated any of the following attributes or HTML properties found in components
    • 'aria-label'
    • 'aria-description'
    • 'title'
    • 'placeholder'
    • 'alt'
    • '@text'
  • Added linting rule to components no-bare-strings which prevents untranslated text nodes

Jira ticket: HDS-4856


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 29, 2025 10:03pm
hds-website ✅ Ready (Inspect) Visit Preview May 29, 2025 10:03pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants