s3: migrate to aws-sdk-go-v2 #516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bschaatsbergen you probably know this already but be aware you will need a @hashicorp/team-ip-compliance review on this PR before it can be merged. For when that time comes. |
bschaatsbergen
commented
Feb 12, 2025
| cfg, err = config.LoadDefaultConfig( | ||
| ctx, | ||
| config.WithRegion(region), | ||
| config.WithEC2IMDSEndpoint(os.Getenv("AWS_METADATA_URL")), |
There was a problem hiding this comment.
It’s unclear to me if this is the right approach and whether it provides feature parity with the current implementation of metadata URL overriding. Something to look into.
|
👋🏻 Hi Bruno - you may have already spotted it, but there's an old PR for the same migration that might be a useful reference: #467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes updating the S3 getter to use the new aws-sdk-go-v2 to take advantage of improved configuration loading and credential chain handling, including support for SSO-fetched credentials, for example.
It’s worth noting that the aws-sdk-go-v2 requires at least Go 1.21, so this PR adds the minimum required version to the
go.modfile.Additionally, this updates the
actions/upload-artifactaction to the latest stable version, as the currently implemented v3 is no longer be usable after January 30th, 2025. See deprecation notice.This is a draft since I’m still working out the details of how the EC2 Metadata Service URL overriding should be handled. If you have any suggestions, feel free to comment them here.