Skip to content

fix: remove double newlines when no variadic argument #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Jun 6, 2025

Related Issue

Fixes #488

Description

Do not render 2 new lines when the function does not have variadic arguments.

@jooola jooola requested a review from a team as a code owner June 6, 2025 13:46
@SBGoods SBGoods force-pushed the function_double_new_line branch from 577264c to e03bf8e Compare June 11, 2025 17:39
@SBGoods SBGoods mentioned this pull request Jun 13, 2025
@SBGoods
Copy link
Contributor

SBGoods commented Jun 13, 2025

Hi @jooola 👋🏾
Thank you for this contribution! The changes look good to me, I've pushed a changelog entry and an acceptance test case for the fix. Since I contributed to this PR, I'll need another member of my team to review it, but we should be able to get this merged next week.

@SBGoods SBGoods merged commit 2f25d2c into hashicorp:main Jun 16, 2025
8 checks passed
@SBGoods SBGoods added command/generate enhancement New feature or request labels Jun 16, 2025
@SBGoods SBGoods added this to the v0.22.0 milestone Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command/generate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendered documentation for function ends with 2 new lines
3 participants