hlint-action error: libtinfo.so.5: cannot open shared object file

[pbrisbin]

GitHub has updated ubuntu-latest,

We're bumping into issues here and there and one is the hlint-run Action failing,

/opt/hostedtoolcache/hlint/3.3.6/x64/hlint: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
hlint completed with status code 127

I've worked around by adding the following step first,

- run: sudo apt-get install -y libncurses5

I'm not sure if hlint-setup should include this?

Annoying because it added ~5s to a Job that's only ~4s in total normally.

[pbrisbin]

FYI I'm now finding that ubuntu-latest == ubuntu-22.04 may not be true yet. We're seeing it, but it's inconsistent and not what the official docs say. So I guess consider this a bug report for anyone using ubuntu-22.04 explicitly, but I think that'll be ubuntu-latest soon.

[andreasabel]

@pbrisbin : Consider reporting this upstream at https://github.com/actions/runner-images/issues if you think that libncurses5 should come by default with ubuntu-22.04. But maybe something in this action can be bumped to libncurses 6. See also https://repology.org/project/ncurses/versions .

[pbrisbin]

Consider reporting this upstream at https://github.com/actions/runner-images/issues if you think that libncurses5 should come by default with ubuntu-22.04

I don't think I do. If I understand things correctly, what's happening is a newer libncurses6 is present because it's a newer Ubuntu. I don't think it would make sense to request they ship an older version of the same library instead or in addition to that.

I just noticed in the linked PR from haskellweekly, that running this action with.version: 3.5 also fixes the issue. That makes me think that the situation is perhaps pretty reasonable: 20.04 + libncurses5 + hlint-3.3 works and 22.04 + libncurses6 + hlint-3.5 works. You either go all older or all newer and it only breaks if you're mixing. It just so happens that the default runner is now newer while the action's default version is older -- so a fully "default" setup is broken.

So one thought could be to move the action's default version up to 3.5 now that ubuntu-latest is 22.04. This way defaults-with-defaults works again.

WDYT?

[andreasabel]

So one thought could be to move the action's default version up to 3.5 now that ubuntu-latest is 22.04. This way defaults-with-defaults works again.

Sounds reasonable.

With the caveat that ubuntu-latest is sometimes still ubuntu-20.04. According to this issue, the migration will only be completed in March 2023:

• Ubuntu-latest workflows will use Ubuntu-22.04 actions/runner-images#6399

[pbrisbin]

Ah thanks for linking that! We've been seeing the intermittent behavior and I'm happy to see an official source that it's due to an ongoing rollout.

[andreasabel]

@rwe: Are you maintaining the hlint actions?

[rwe]

@andreasabel I haven't been touching them since the fork here—they were subtreed so I didn't see it actually occur. And despite being the author I don't have commit access here.

But I might have some time to take a look and review today if there's anything I can contribute.

[andreasabel]

@rwe : I think @hazelweakly can give you commit rights. I guess she would be happy to get some maintenance help.

[andreasabel]

@rwe: I lack the rights to give you rights, but I can merge and publish a PR if you provide one.