Skip to content

Fix toMethodName bug of the Class plugin #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Fix toMethodName bug of the Class plugin #1170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379f590
Fix toMethodName bug of the Class plugin
Ailrun Jan 7, 2021
d4e666a
Add class plugin test for _
Ailrun Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix toMethodName bug of the Class plugin
  • Loading branch information
@Ailrun
Ailrun committed Jan 7, 2021
commit 379f590873fb58b5e7c2cb0bb561a377ae53d4cc
2 changes: 1 addition & 1 deletion plugins/hls-class-plugin/src/Ide/Plugin/Class.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ addMethodPlaceholders lf state AddMinimalMethodsParams{..} = fmap (fromMaybe err

toMethodName n
| Just (h, _) <- T.uncons n
, not (isAlpha h)
, not (isAlpha h || h == '_')
= "(" <> n <> ")"
| otherwise
= n
Expand Down