Skip to content

Break down ghcide functionality in HLS plugins #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 25, 2021
+214 −237
Merged

Break down ghcide functionality in HLS plugins #1257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
774cc27
Clean up no longer needed handlers
pepeiborra Jan 17, 2021
c125ddb
Move some log lines to debug verbosity
pepeiborra Jan 17, 2021
704b21d
Extract type signature code lenses to an HLS plugin
pepeiborra Jan 24, 2021
c276978
Extract the block command handler to an HLS plugin
pepeiborra Jan 17, 2021
fb9dbc7
fix command capability check
pepeiborra Jan 17, 2021
d59cac4
Extract completions into an HLS plugin
pepeiborra Jan 23, 2021
5d7571e
Extract code actions into an HLS plugin
pepeiborra Jan 24, 2021
5bf939e
Group ghcide plugins
pepeiborra Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move some log lines to debug verbosity
  • Loading branch information
@pepeiborra
pepeiborra committed Jan 24, 2021
commit c125ddbcdb7745b739d60929c33504b7caecc3f3
4 changes: 2 additions & 2 deletions ghcide/src/Development/IDE/Plugin/HLS.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ import qualified Language.Haskell.LSP.VFS as VFS
import Text.Regex.TDFA.Text()
import Development.Shake (Rules)
import Ide.PluginUtils (getClientConfig, pluginEnabled, getPluginConfig, responseError, getProcessID)
import Development.IDE.Types.Logger (logInfo)
import Development.IDE.Core.Tracing
import Development.IDE.Types.Logger (logDebug)
import Control.Concurrent.Async (mapConcurrently)

-- ---------------------------------------------------------------------
Expand Down Expand Up @@ -156,7 +156,7 @@ makeCodeLens :: [(PluginId, CodeLensProvider IdeState)]
-> CodeLensParams
-> IO (Either ResponseError (List CodeLens))
makeCodeLens cas lf ideState params = do
logInfo (ideLogger ideState) "Plugin.makeCodeLens (ideLogger)" -- AZ
logDebug (ideLogger ideState) "Plugin.makeCodeLens (ideLogger)" -- AZ
let
makeLens (pid, provider) = do
pluginConfig <- getPluginConfig lf pid
Expand Down
2 changes: 1 addition & 1 deletion ghcide/src/Development/IDE/Plugin/HLS/GhcIde.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ descriptor plId = (defaultPluginDescriptor plId)

hover' :: HoverProvider IdeState
hover' ideState params = do
logInfo (ideLogger ideState) "GhcIde.hover entered (ideLogger)" -- AZ
logDebug (ideLogger ideState) "GhcIde.hover entered (ideLogger)" -- AZ
hover ideState params

-- ---------------------------------------------------------------------
Expand Down