Skip to content

Implements :type [+v/+d] in Eval Plugin #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 29, 2020
Merged

Implements :type [+v/+d] in Eval Plugin #361

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f7302bb
More systematic handling of GHCi-like commands
konn Aug 29, 2020
8ab64c9
Human-readable Show for GhciLikeCmdException
konn Aug 29, 2020
c68d3b4
Use `T.strip` instead of `T.stripEnd`
konn Aug 29, 2020
389f101
Implements `:type` command and their tests
konn Aug 29, 2020
c4dd53e
Adds test case for unknown `TcRnExprMode` argument
konn Aug 29, 2020
54c5d9f
Adds test case for unknown command
konn Aug 29, 2020
3e7edce
Simplifies test case T16
konn Aug 29, 2020
7955721
Corrects mode option
konn Aug 29, 2020
907797e
Adds test-case with defaulting clause inside >>> prompt
konn Aug 29, 2020
ce9274c
Fixes for redundant imports
konn Aug 29, 2020
e487085
Reorganises import list
konn Aug 29, 2020
02c51d4
Elaborates on the Exception argument roles
konn Aug 29, 2020
6740e0c
Adds a test-case for module defaulting, marked as expected failure
konn Aug 29, 2020
ad2ebe5
Uses `expectFailBecause` instead
konn Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use T.strip instead of T.stripEnd
  • Loading branch information
@konn
konn committed Aug 29, 2020
commit c68d3b4fea6f08d57bf2514cc803c822bfcd5834
2 changes: 1 addition & 1 deletion src/Ide/Plugin/Eval.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ instance E.Exception GhciLikeCmdException
parseGhciLikeCmd :: Text -> Maybe (Text, Text)
parseGhciLikeCmd input = do
(':', rest) <- T.uncons $ T.stripStart input
pure $ second T.stripEnd $ T.break isSpace rest
pure $ second T.strip $ T.break isSpace rest

strictTry :: NFData b => IO b -> IO (Either String b)
strictTry op = E.catch
Expand Down