-
Notifications
You must be signed in to change notification settings - Fork 95
Merge lsp-test into lsp repo #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix haddock
And bump haskell-lsp and resolver
Add MonadFail constraint for GHC 8.6.1
Bump version and update version constraints
Add Type definition request
Update README to include instructions on how to run tests
use Text instead of String
respond to progress create and apply edit
Bump lsp commit
…ntext-diagnostics-to-range Limit diagnostics by range in getCodeActions
Kill timeout thread to prevent TimeoutMessages from clogging up the queue
update equality function
cf23142
to
0188434
Compare
The dummy-server now runs in the same process using the `runSessionWithHandles` trick
0188434
to
7250d76
Compare
wz1000
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is this ready?
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #277, this moves
lsp-test
into this repo so thatlsp
,lsp-types
andlsp-test
are all kept in sync. In the next releaselsp-test
should adopt the same version numbers aslsp[-types]
.The next step after this, migrating this repo to the Haskell org.