Skip to content

Make sure no empty strings in server executable args #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2021
Merged

Make sure no empty strings in server executable args #469

merged 1 commit into from
Sep 25, 2021

Conversation

berberman
Copy link
Collaborator

Closes #468

It seems that vscode-languageclient will concatenate the arguments array into a string that our server won't accept if there are blank strings in the array.

@berberman berberman mentioned this pull request Sep 25, 2021
Closed
jneira
jneira approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for the quick fix merging

@jneira jneira merged commit 3f8c5ae into haskell:master Sep 25, 2021
@jneira
Copy link
Member

jneira commented Sep 25, 2021

@berberman could you cut a minor release with the fix, I will not be able to do it for some time
I think you will have the needed perms, only push the tag and make a release is needed to trigger CI publish
many thanks!

@berberman berberman deleted the args branch September 25, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 1.7.0 seems broken (for Ubuntu 20.04)
2 participants
@berberman @jneira