Add traces for download hls #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mduerig
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
I think the behaviour itself is correct as the extension keeps functioning the way it was until the user decides to update (i.e. by setting update behaviour to keep-up-to-date. But being more explicit about this surely a good thing. Maybe worth adding a note to the release notes and the documentation as well.
mduerig
approved these changes
Nov 25, 2021
mduerig
approved these changes
Nov 25, 2021
|
@mduerig thanks for take a look, will merge
Will add it in the pr which will prepare the extension for the incoming release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more traces and suggestions for users
I find a corner case where the behaviour is not ideal: if you have downloaded the old release metadada for 1.5.0 and then you have set
haskell.updateBehaviourtonever-check, the unique release info in the new release metadata is 1.5.0 and it will fail to use a possibly existing hls-1.4.0-8.10.4 (as the info for such binary is in the release metadata for 1.4.0)It is fixed setting again
haskell.updateBehaviourtoup-to-dateso i've suggested use that to try to find a binary in "other releases" (newer or older)//cc @mduerig