Fix entry point re-exports #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
verify |
puzpuzpuz
force-pushed
the
v4.0/cleanup/refactor-modules
branch
from
31844ab to
ad61c99
Compare
puzpuzpuz
force-pushed
the
v4.0/cleanup/refactor-modules
branch
from
ad61c99 to
183ff59
Compare
Includes the following: * Introduces index.ts files in subdirs for the purpose of re-exporting public modules * Introduces Portable module which contains public API definitions for portable serialization * Moves modules into subdirs, so the overall structure is more consistent * Merges certain related modules into a single one * Changes MembershipListener registration id type to string (was UUID), so it becomes consistent with registration types for other listeners (e.g. IMap#addEntryListener) * Adds documentation for wildcard names and default DS configurations * Includes a bunch of improvements in tsdoc and code style
puzpuzpuz
force-pushed
the
v4.0/cleanup/refactor-modules
branch
from
183ff59 to
6dfda9a
Compare
Merged
mdumandag
reviewed
Aug 17, 2020
Also improves code style is some tests
@mdumandag It seems that I have addressed all pending comments. Could you take another look? |
mdumandag
approved these changes
Aug 18, 2020
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
Includes the following: * Introduces index.ts files in subdirs for the purpose of re-exporting public modules * Introduces Portable module which contains public API definitions for portable serialization * Moves modules into subdirs, so the overall structure is more consistent * Merges certain related modules into a single one * Changes MembershipListener registration id type to string (was UUID), so it becomes consistent with registration types for other listeners (e.g. IMap#addEntryListener) * Adds documentation for wildcard names and default DS configurations * Includes a bunch of improvements in tsdoc and code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #568
index.tsfiles in subdirs for the purpose of re-exporting public modules. This way rootindex.ts(the entry point) becomes much simpler and it's simpler to make sure that we export all public APIs from the entry pointPortablemodule which contains public API definitions for portable serializationMembershipListenerregistration id type tostring(wasUUID), so it becomes consistent with registration types for other listeners (e.g.IMap#addEntryListener)Client protocol counterpart PR: hazelcast/hazelcast-client-protocol#336