refactor: migrate eslint to v9 #5267
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update modernizes and refines the project's linting and formatting setup. The legacy Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant ESLint
participant Project Files
Developer->>ESLint: Run lint (via script or pre-commit)
ESLint->>eslint.config.mjs: Load flat config and ignore patterns
ESLint->>Project Files: Lint all JS/TS files (excluding ignored patterns)
Project Files-->>ESLint: Provide source code
ESLint-->>Developer: Report issues, auto-fix where possible
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
packages/components/autocomplete/src/use-autocomplete.ts (1)
147-154:⚠️ Potential issue
isClearablemay becomeundefined; coerce to booleanWhen
isReadOnlyisfalseandoriginalProps.isClearableis omitted,isClearablewill beundefined, yet downstream styling and logic treat it as a boolean.- : originalProps.isReadOnly - ? false - : originalProps.isClearable; + : originalProps.isReadOnly + ? false + : Boolean(originalProps.isClearable);This prevents accidental truthy/falsey coercion bugs later.
🧹 Nitpick comments (3)
packages/components/checkbox/src/use-checkbox.ts (1)
326-334: Cast placement is safer, but considersatisfiesfor future-proofingMoving the
as CheckboxIconPropscast outside the object avoids partial-typed literals and works today; however, once you move to TS 5.0+ you could drop the cast completely withreturn { /* … */ } satisfies CheckboxIconProps;to retain literal inference while still type-checking.
packages/components/autocomplete/src/use-autocomplete.ts (2)
398-407: Nit: type assertion can be dropped once generics propagateThe cast to
ButtonPropsis only needed because the return literal isn’t generic-aware. If you ever lift this helper out, consider givinggetSelectorButtonPropsits own return type so the assertion can be removed.
438-451: Same observation forInputPropsCasting the object to
InputPropsis fine, but a dedicatedtype/generic would avoid theunknown asdance.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (58)
.eslintignore(0 hunks).eslintrc.json(0 hunks).lintstagedrc.cjs(1 hunks)apps/docs/app/examples/autocomplete/async-filtering/page.tsx(0 hunks)apps/docs/app/examples/table/custom-styles/page.tsx(0 hunks)apps/docs/app/examples/table/use-case/page.tsx(0 hunks)apps/docs/components/ads/carbon-ad/carbon-ad.tsx(1 hunks)apps/docs/components/ads/carbon-ad/carbon-optimize.js(0 hunks)apps/docs/components/blog/video-in-view.tsx(0 hunks)apps/docs/components/cmdk.tsx(1 hunks)apps/docs/components/docs/components/code-demo/code-demo.tsx(1 hunks)apps/docs/components/marketing/a11y-otb.tsx(0 hunks)apps/docs/components/marketing/custom-themes/custom-themes.tsx(0 hunks)apps/docs/components/marketing/customization.tsx(0 hunks)apps/docs/components/marketing/dark-mode.tsx(0 hunks)apps/docs/components/marketing/last-but-not-least.tsx(0 hunks)apps/docs/components/marketing/support.tsx(1 hunks)apps/docs/components/mdx-components.tsx(0 hunks)apps/docs/hooks/use-scroll-position.ts(0 hunks)apps/docs/hooks/use-scroll-spy.ts(0 hunks)apps/docs/hooks/use-update-effect.ts(0 hunks)apps/docs/libs/github/utils.ts(1 hunks)apps/docs/libs/rehype-highlight-line.js(0 hunks)apps/docs/scripts/build-sponsors.ts(1 hunks)apps/docs/scripts/update-search-meta.ts(1 hunks)apps/docs/utils/get-sponsors.ts(1 hunks)eslint.config.mjs(1 hunks)package.json(4 hunks)packages/components/autocomplete/src/use-autocomplete.ts(4 hunks)packages/components/avatar/stories/avatar-group.stories.tsx(0 hunks)packages/components/calendar/__tests__/calendar.test.tsx(0 hunks)packages/components/card/stories/card.stories.tsx(0 hunks)packages/components/checkbox/src/use-checkbox.ts(2 hunks)packages/components/checkbox/stories/checkbox.stories.tsx(1 hunks)packages/components/input-otp/stories/input-otp.stories.tsx(0 hunks)packages/components/modal/stories/modal.stories.tsx(0 hunks)packages/components/number-input/stories/number-input.stories.tsx(0 hunks)packages/components/pagination/__tests__/pagination.test.tsx(1 hunks)packages/components/pagination/src/pagination.tsx(1 hunks)packages/components/select/src/hidden-select.tsx(1 hunks)packages/components/select/src/use-select.ts(1 hunks)packages/components/select/stories/select.stories.tsx(0 hunks)packages/components/slider/src/use-slider.ts(1 hunks)packages/components/slider/stories/slider.stories.tsx(0 hunks)packages/components/snippet/src/use-snippet.ts(1 hunks)packages/components/switch/stories/switch.stories.tsx(0 hunks)packages/components/tooltip/src/tooltip.tsx(1 hunks)packages/core/system-rsc/src/extend-variants.d.ts(1 hunks)packages/hooks/use-callback-ref/src/index.ts(0 hunks)packages/hooks/use-intersection-observer/src/index.ts(1 hunks)packages/hooks/use-update-effect/src/index.ts(0 hunks)packages/utilities/react-utils/src/dimensions.ts(1 hunks)packages/utilities/react-utils/src/refs.ts(1 hunks)packages/utilities/shared-utils/scripts/postinstall.js(1 hunks)packages/utilities/shared-utils/src/common/clsx.ts(0 hunks)packages/utilities/shared-utils/src/common/functions.ts(1 hunks)packages/utilities/test-utils/src/dom.ts(1 hunks)packages/utilities/test-utils/src/drag.ts(1 hunks)
💤 Files with no reviewable changes (29)
- apps/docs/components/marketing/customization.tsx
- apps/docs/hooks/use-scroll-position.ts
- apps/docs/components/blog/video-in-view.tsx
- apps/docs/app/examples/autocomplete/async-filtering/page.tsx
- apps/docs/components/marketing/last-but-not-least.tsx
- packages/utilities/shared-utils/src/common/clsx.ts
- packages/components/slider/stories/slider.stories.tsx
- packages/components/modal/stories/modal.stories.tsx
- apps/docs/components/mdx-components.tsx
- apps/docs/hooks/use-scroll-spy.ts
- apps/docs/components/marketing/dark-mode.tsx
- packages/components/switch/stories/switch.stories.tsx
- packages/components/number-input/stories/number-input.stories.tsx
- apps/docs/components/marketing/custom-themes/custom-themes.tsx
- packages/hooks/use-update-effect/src/index.ts
- packages/hooks/use-callback-ref/src/index.ts
- packages/components/avatar/stories/avatar-group.stories.tsx
- packages/components/calendar/tests/calendar.test.tsx
- apps/docs/components/marketing/a11y-otb.tsx
- packages/components/select/stories/select.stories.tsx
- apps/docs/libs/rehype-highlight-line.js
- apps/docs/app/examples/table/use-case/page.tsx
- packages/components/input-otp/stories/input-otp.stories.tsx
- apps/docs/hooks/use-update-effect.ts
- packages/components/card/stories/card.stories.tsx
- apps/docs/app/examples/table/custom-styles/page.tsx
- apps/docs/components/ads/carbon-ad/carbon-optimize.js
- .eslintrc.json
- .eslintignore
🧰 Additional context used
🧬 Code Graph Analysis (3)
apps/docs/components/cmdk.tsx (1)
packages/utilities/shared-utils/src/common/assertion.ts (1)
isEmpty(26-32)
packages/components/autocomplete/src/use-autocomplete.ts (2)
packages/components/button/src/button.tsx (1)
ButtonProps(7-7)packages/components/input/src/input.tsx (1)
InputProps(7-7)
packages/components/select/src/use-select.ts (1)
packages/components/select/src/hidden-select.tsx (1)
HiddenSelectProps(35-44)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: TypeScript
- GitHub Check: Tests
- GitHub Check: Build
- GitHub Check: Continuous Release
🔇 Additional comments (28)
apps/docs/components/docs/components/code-demo/code-demo.tsx (2)
22-23: ESLint disable comment removedThe ESLint disable comment for
react/display-namehas been removed as part of the ESLint v9 migration. This suggests that either the rule has been configured differently in the new flat config or the issue is no longer relevant with the updated linting rules.
29-30: ESLint disable comment removedSimilar to the previous instance, the ESLint disable comment for
react/display-namehas been removed from the dynamic import ofDynamicSandpack. This is consistent with the ESLint v9 migration approach throughout the codebase.packages/utilities/shared-utils/scripts/postinstall.js (1)
7-7: Unused error parameter removedThe catch clause has been simplified by removing the unused error parameter
e. This is good practice as it avoids declaring variables that aren't used, which helps satisfy linting rules that warn about unused variables.packages/utilities/test-utils/src/dom.ts (1)
18-18: Improved expression clarity with parenthesesParentheses have been added around the nullish coalescing expression
(node.ownerDocument ?? document)in the ternary operator. This enhances readability by explicitly grouping the expression without changing the functionality.packages/utilities/shared-utils/src/common/functions.ts (1)
156-156: Unused error parameter removedThe catch clause has been simplified by removing the unused error parameter. This is a good practice that aligns with modern JavaScript conventions to avoid declaring variables that aren't used in the code block.
apps/docs/libs/github/utils.ts (1)
10-10: Good cleanup: Removed unused error parameter.The change removes an unused error parameter from the catch clause, resulting in cleaner and more concise code since the error object isn't used in the catch block.
packages/components/checkbox/stories/checkbox.stories.tsx (1)
257-258: LGTM: Removed unnecessary ESLint directive comment.This change removes an ESLint directive comment that was previously disabling the
react/display-namerule. With ESLint v9's configuration, this directive is no longer needed, which helps maintain cleaner code without excessive comments.apps/docs/scripts/build-sponsors.ts (1)
51-51: Good cleanup: Removed unused error parameter.Similar to other changes in this PR, this removes an unused error parameter from the catch clause, improving code clarity. The catch block only needs to handle the exception without accessing the error details.
apps/docs/components/cmdk.tsx (1)
213-213: Improved code clarity with explicit parentheses.Adding parentheses around the fallback expression
(recentSearches ?? [])enhances readability by making the operator precedence explicit. This is a good style improvement without changing the functionality.packages/hooks/use-intersection-observer/src/index.ts (1)
96-96: Linting rule enforcement improvementThe removal of the ESLint disable comment for react-hooks/exhaustive-deps is a good change that enforces better dependency tracking in the useEffect hook. This aligns with the PR's objective of migrating to ESLint v9 and standardizing linting behavior.
packages/utilities/react-utils/src/dimensions.ts (1)
11-12: Improved code readabilityThe adjusted indentation of the nested ternary expressions improves code readability by properly aligning the conditional branches. This makes the logic flow clearer and easier to follow.
packages/utilities/react-utils/src/refs.ts (1)
24-24: Simplified error handlingGood simplification of the catch block by removing the unused error parameter while maintaining the same error handling behavior. This change aligns with modern JavaScript best practices for cleaner code.
packages/core/system-rsc/src/extend-variants.d.ts (1)
31-34: Enhanced type definition readabilityThe improved indentation in the complex type definition makes the nested structure clearer. This formatting change makes the conditional type relationships more visible and easier to understand for developers working with this code.
apps/docs/components/ads/carbon-ad/carbon-ad.tsx (1)
94-96: Clean error handling improvement.Good change removing the unused error parameter from the catch block, making the code cleaner while maintaining the same fallback behavior.
packages/components/snippet/src/use-snippet.ts (1)
245-245: Consistent type assertion formatting.Good change standardizing the TypeScript type assertion placement, which aligns with modern style conventions without changing functionality.
packages/components/slider/src/use-slider.ts (1)
255-256: Improved code readability.Good formatting change that enhances the readability of the nested ternary expression by using proper indentation, making the code structure clearer.
apps/docs/components/marketing/support.tsx (1)
12-14: Clean error handling improvement.Good change removing the unused error parameter from the catch block, making the code cleaner while maintaining the same error handling behavior.
packages/components/pagination/__tests__/pagination.test.tsx (1)
97-98: Improved nested ternary readabilityThe indentation of the nested ternary expression has been improved, making the code easier to read and understand. This change follows good formatting practices for nested conditionals.
apps/docs/utils/get-sponsors.ts (1)
23-23: Simplified catch clauseRemoving the unused error parameter in the catch clause makes the code cleaner while maintaining the same functionality. This is in line with modern JavaScript practices for handling unused parameters.
.lintstagedrc.cjs (1)
19-19:✅ Verification successful
Updated ESLint configuration approach
The explicit reference to
.eslintrc.jsonhas been removed from the ESLint command, allowing ESLint to automatically use the new flat config format. This aligns with the migration to ESLint v9.
🏁 Script executed:
#!/bin/bash # Check if eslint.config.mjs exists in the project find . -maxdepth 1 -name "eslint.config.mjs" -type f # Check if the old .eslintrc.json still exists find . -maxdepth 1 -name ".eslintrc.json" -type fLength of output: 122
Confirm usage of new flat ESLint config
The project root now contains
eslint.config.mjsand no longer has.eslintrc.json, so removing the explicit config reference in the lint-staged command is correct. The command in.lintstagedrc.cjs(line 19) can safely rely on ESLint v9’s flat config resolution.apps/docs/scripts/update-search-meta.ts (1)
104-104: Simplified empty catch clauseThe unused error parameter has been removed from the catch block, making the code more concise while maintaining the same error handling behavior. This pattern is consistently applied across the codebase as part of the ESLint modernization effort.
packages/components/pagination/src/pagination.tsx (1)
126-127: Improved code indentation for clarity.The indentation of the nested ternary expression is now properly aligned, making the code more readable and consistent with the project's formatting standards.
packages/components/select/src/hidden-select.tsx (1)
107-107: Enhanced expression clarity with parentheses.Adding parentheses around the fallback expression
([...state.selectedKeys][0] ?? "")improves code readability by explicitly grouping the operations, making the intent clearer.packages/components/select/src/use-select.ts (1)
498-498: Improved TypeScript type assertion style.The type assertion has been moved outside the returned object literal, which follows a more consistent and modern TypeScript pattern. This change aligns with the code style improvements being made throughout the codebase as part of the ESLint migration.
packages/components/tooltip/src/tooltip.tsx (1)
57-57: Simplified catch block by removing unused parameter.Removing the unused error parameter from the catch block follows clean code practices and reduces unnecessary variables, while maintaining the same functionality.
packages/utilities/test-utils/src/drag.ts (1)
78-79: Formatting-only change looks goodIndentation of the nested ternary now matches the project style and improves readability without altering behaviour.
packages/components/checkbox/src/use-checkbox.ts (1)
100-107: Precedence clarified, LGTMWrapping the fallback of
isInvalidPropandvalidationBehaviorin parentheses removes any ambiguity in the ternary evaluation order. Good defensive coding.package.json (1)
65-106: Verify plugin compatibility with ESLint 9You’ve bumped
eslintto^9.26.0, but many ecosystem plugins haven’t reached full v9 support. If any plugin still declares a peer-dep of<9, installs will warn or break.Please run a quick peer-dependency audit (
npm ls --depth=1 | grep eslint) or similar before merging.
@heroui/accordion
@heroui/autocomplete
@heroui/alert
@heroui/avatar
@heroui/badge
@heroui/breadcrumbs
@heroui/button
@heroui/calendar
@heroui/card
@heroui/checkbox
@heroui/chip
@heroui/code
@heroui/date-input
@heroui/date-picker
@heroui/divider
@heroui/drawer
@heroui/dropdown
@heroui/form
@heroui/image
@heroui/input
@heroui/input-otp
@heroui/kbd
@heroui/listbox
@heroui/link
@heroui/menu
@heroui/modal
@heroui/navbar
@heroui/number-input
@heroui/pagination
@heroui/popover
@heroui/progress
@heroui/radio
@heroui/ripple
@heroui/scroll-shadow
@heroui/select
@heroui/skeleton
@heroui/slider
@heroui/snippet
@heroui/spacer
@heroui/spinner
@heroui/switch
@heroui/table
@heroui/tabs
@heroui/toast
@heroui/tooltip
@heroui/user
@heroui/react
@heroui/system
@heroui/system-rsc
@heroui/theme
@heroui/use-aria-accordion
@heroui/use-aria-accordion-item
@heroui/use-aria-button
@heroui/use-aria-link
@heroui/use-aria-modal-overlay
@heroui/use-aria-multiselect
@heroui/use-callback-ref
@heroui/use-clipboard
@heroui/use-data-scroll-overflow
@heroui/use-disclosure
@heroui/use-draggable
@heroui/use-image
@heroui/use-infinite-scroll
@heroui/use-intersection-observer
@heroui/use-is-mobile
@heroui/use-is-mounted
@heroui/use-measure
@heroui/use-real-shape
@heroui/use-pagination
@heroui/use-ref-state
@heroui/use-resize
@heroui/use-safe-layout-effect
@heroui/use-scroll-position
@heroui/use-ssr
@heroui/use-theme
@heroui/use-update-effect
@heroui/aria-utils
@heroui/dom-animation
@heroui/framer-utils
@heroui/react-rsc-utils
@heroui/react-utils
@heroui/shared-icons
@heroui/shared-utils
@heroui/stories-utils
@heroui/test-utils
commit: |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (3)
eslint.config.mjs (3)
52-57:⚠️ Potential issueMissing react-hooks plugin import
You're extending
"plugin:react-hooks/recommended"but haven't imported the react-hooks plugin.Add the import and plugin entry:
-import react from "eslint-plugin-react"; +import react from "eslint-plugin-react"; +import reactHooks from "eslint-plugin-react-hooks"; ... plugins: { react: fixupPluginRules(react), + "react-hooks": reactHooks, "unused-imports": unusedImports,Without this, ESLint will throw an error when loading the config.
59-66:⚠️ Potential issueAdd react-hooks to plugins configuration
The plugin section needs to include the react-hooks plugin to match the extended configuration.
plugins: { react: fixupPluginRules(react), + "react-hooks": reactHooks, "unused-imports": unusedImports, import: fixupPluginRules(_import), "@typescript-eslint": typescriptEslint, "jsx-a11y": fixupPluginRules(jsxA11Y), prettier: fixupPluginRules(prettier), },
95-104: 🛠️ Refactor suggestionRe-enable react-hooks/exhaustive-deps rule
Disabling this rule hides a whole class of stale-closure bugs. With the plugin now present, you should enable it.
-"react-hooks/exhaustive-deps": "off", +"react-hooks/exhaustive-deps": "warn",Consider stricter settings (
"error") once the codebase is clean.
🧹 Nitpick comments (1)
eslint.config.mjs (1)
68-73: Consider reviewing global variables configurationThe approach of disabling all browser globals might be too restrictive. Consider enabling specific browser globals that might be needed for your application.
globals: { - ...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, "off"])), + // Selectively enable browser globals that are needed + window: "readonly", + document: "readonly", + fetch: "readonly", ...globals.node, },
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/docs/scripts/update-github-info.ts(1 hunks)eslint.config.mjs(1 hunks)package.json(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: TypeScript
- GitHub Check: Tests
- GitHub Check: Continuous Release
- GitHub Check: Build
- GitHub Check: Prettier
🔇 Additional comments (7)
apps/docs/scripts/update-github-info.ts (1)
38-38: Good improvement: Added proper async handling for prettier.formatThe addition of
awaitcorrectly handles the asynchronous nature ofprettier.format(). This ensures that the JSON formatting operation completes before the formatted content is written to the file.eslint.config.mjs (6)
1-15: LGTM: Good plugin imports and configuration setupThe imports are comprehensive and well-structured, including all necessary plugins for TypeScript, React, accessibility, and code style enforcement.
24-51: Comprehensive ignore patterns implementedThe global ignore patterns effectively replace the previous
.eslintignorefile, providing comprehensive coverage of build artifacts, dependency folders, and configuration files.
104-113: Good unused variable handling configurationThe configuration properly disables core ESLint and unused-imports unused variable rules in favor of the TypeScript-specific version, with appropriate patterns for argument handling.
114-133: Well-structured import ordering rulesThe import ordering configuration is comprehensive with appropriate grouping and newline requirements. The inclusion of path patterns for internal modules is a good practice.
135-142: Good JSX formatting rulesThe self-closing component and JSX prop sorting rules promote consistency and readability in React components.
144-159: Comprehensive code style and formatting rulesThe padding line between statements and type import style rules promote consistent and readable code.
* fix(date-picker): error state (#5317) * fix(date-range-picker): fixed the error state in preset * Update giant-sloths-shop.md * Removed if statement * chore(date-picker): prettier --------- Co-authored-by: WK Wong <[email protected]> * fix(theme): clear button in mobile (#5252) * fix(toast): fixed close button hover position * fix(input): fixed the clear button rendering on smaller devices * Delete .changeset/soft-spoons-march.md * Update input.ts * Undo unrelated toast changes * fix(toast): icons (#5246) * feat(shared-icons): add loading icon * fix(toast): icons * chore(toast): revise types for icons * chore(changeset): add changeset * refactor: migrate eslint to v9 (#5267) * refactor: migrate eslint to v9 * chore: lint * chore: update eslint command * chore: fix lint warnings * chore: separate lint and lint:fix * chore: exclude contentlayer generated code * fix(scripts): add missing await * fix(autocomplete): persist last selected item position (#5286) * refactor(select): remove unnecessary code * fix(autocomplete): persist last selected item position * chore(changeset): add changeset * chore(deps): bump framer-motion version (#5287) * chore(deps): bump framer-motion version * fix: typing issues * chore(changeset): add changeset --------- Co-authored-by: Junior Garcia <[email protected]> * chore(docs): supplement onAction & selectionBehavior (#5289) * fix(autocomplete): ensure focused item matches selected item after filter, selection (#5290) * fix(autocomplete): ensure focused item matches selected item after filter, selection * chore: apply type and default value * chore: add perpose coment in updated code * test: add focuskey management testcode * docs: add changeset * docs: update changeset * chore: remove comment * fix: broken components in stories (#5291) * chore(switch): remove xl size * chore(docs): remove xl size * chore(system-rsc): remove xl size * chore(circular-progress): remove xl size * chore: undo * chore(deps): bump RA versions (#5310) * chore(deps): ra version bump * chore(changeset): add changeset * fix(scripts): incorrect docs path --------- Co-authored-by: Junior Garcia <[email protected]> * chore(docs): update meta data (#5311) * docs(layout.tsx): added text-foreground (#5316) * feat(tabs): add click handling for tab items in tests and implementation (#3917) Co-authored-by: WK Wong <[email protected]> * fix issues in tabs examples (#2405) Co-authored-by: WK Wong <[email protected]> * chore(docs): add missing onValueChange in CheckboxGroup (#5332) * ci(changesets): version packages (#5323) Co-authored-by: Junior Garcia <[email protected]> --------- Co-authored-by: Vishv Salvi <[email protected]> Co-authored-by: WK Wong <[email protected]> Co-authored-by: KumJungMin <[email protected]> Co-authored-by: liaoyinglong <[email protected]> Co-authored-by: zhengjitf <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore: add herohack announcement * fix(date-picker): error state (#5317) * fix(date-range-picker): fixed the error state in preset * Update giant-sloths-shop.md * Removed if statement * chore(date-picker): prettier --------- Co-authored-by: WK Wong <[email protected]> * chore: banner replacement * fix(theme): clear button in mobile (#5252) * fix(toast): fixed close button hover position * fix(input): fixed the clear button rendering on smaller devices * Delete .changeset/soft-spoons-march.md * Update input.ts * Undo unrelated toast changes * fix(toast): icons (#5246) * feat(shared-icons): add loading icon * fix(toast): icons * chore(toast): revise types for icons * chore(changeset): add changeset * refactor: migrate eslint to v9 (#5267) * refactor: migrate eslint to v9 * chore: lint * chore: update eslint command * chore: fix lint warnings * chore: separate lint and lint:fix * chore: exclude contentlayer generated code * fix(scripts): add missing await * fix(autocomplete): persist last selected item position (#5286) * refactor(select): remove unnecessary code * fix(autocomplete): persist last selected item position * chore(changeset): add changeset * chore(deps): bump framer-motion version (#5287) * chore(deps): bump framer-motion version * fix: typing issues * chore(changeset): add changeset --------- Co-authored-by: Junior Garcia <[email protected]> * chore(docs): supplement onAction & selectionBehavior (#5289) * fix(autocomplete): ensure focused item matches selected item after filter, selection (#5290) * fix(autocomplete): ensure focused item matches selected item after filter, selection * chore: apply type and default value * chore: add perpose coment in updated code * test: add focuskey management testcode * docs: add changeset * docs: update changeset * chore: remove comment * fix: broken components in stories (#5291) * chore(switch): remove xl size * chore(docs): remove xl size * chore(system-rsc): remove xl size * chore(circular-progress): remove xl size * chore: undo * chore(deps): bump RA versions (#5310) * chore(deps): ra version bump * chore(changeset): add changeset * fix(scripts): incorrect docs path --------- Co-authored-by: Junior Garcia <[email protected]> * chore(docs): update meta data (#5311) * docs(layout.tsx): added text-foreground (#5316) * feat(tabs): add click handling for tab items in tests and implementation (#3917) Co-authored-by: WK Wong <[email protected]> * fix issues in tabs examples (#2405) Co-authored-by: WK Wong <[email protected]> * chore(docs): add missing onValueChange in CheckboxGroup (#5332) * ci(changesets): version packages (#5323) Co-authored-by: Junior Garcia <[email protected]> * chore: remove pre.json --------- Co-authored-by: Junior Garcia <[email protected]> Co-authored-by: Vishv Salvi <[email protected]> Co-authored-by: KumJungMin <[email protected]> Co-authored-by: liaoyinglong <[email protected]> Co-authored-by: zhengjitf <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit