Skip to content

feat: extend setPayableAmount #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

feat: extend setPayableAmount #3144

merged 3 commits into from
Jun 5, 2025

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jun 3, 2025

Description:
Extends setPayableAmount function in ContractExecuteTransaction, by allowing the user to pass a HbarUnit as optional second parameter.

Related issue(s):

Fixes #3129

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov self-assigned this Jun 3, 2025
@0xivanov 0xivanov added the enhancement New feature or request label Jun 3, 2025
@lfdt-bot
Copy link
Contributor

lfdt-bot commented Jun 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/Hbar.js 96.92% <100.00%> (ø)
src/contract/ContractExecuteTransaction.js 98.55% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov marked this pull request as ready for review June 5, 2025 08:20
@0xivanov 0xivanov requested review from a team as code owners June 5, 2025 08:20
@0xivanov 0xivanov requested a review from agadzhalov June 5, 2025 08:20
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov merged commit 1c2265d into main Jun 5, 2025
19 checks passed
@0xivanov 0xivanov deleted the 3129-extend-setPayableAmount branch June 5, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigNumber input in setPayableAmount treated as Hbar not Tinybar
4 participants