Skip to content

[benchmarks] overhaul benchmarks #11565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
24a46cc
start overhauling the benchmarking suite.
sayakpaul May 15, 2025
ab7f381
fixes
sayakpaul May 15, 2025
cc0a38a
fixes
sayakpaul May 15, 2025
169f831
checking.
sayakpaul May 15, 2025
ad18983
checking
sayakpaul May 15, 2025
31e34d5
fixes.
sayakpaul May 16, 2025
36afdea
error handling and logging.
sayakpaul May 16, 2025
0d3af90
Merge branch 'main' into benchmarking-overhaul
sayakpaul May 16, 2025
fd85fbc
Merge branch 'main' into benchmarking-overhaul
sayakpaul May 19, 2025
a2c03a4
Merge branch 'main' into benchmarking-overhaul
sayakpaul May 20, 2025
4d83a47
add flops and params.
sayakpaul May 20, 2025
6815cae
add more models.
sayakpaul May 20, 2025
5635bf8
utility to fire execution of all benchmarking scripts.
sayakpaul May 20, 2025
cfbd21e
utility to push to the hub.
sayakpaul May 20, 2025
4ccfad0
push utility improvement
sayakpaul May 20, 2025
dff3144
seems to be working.
sayakpaul May 20, 2025
accd598
okay
sayakpaul May 20, 2025
41f79a0
add torchprofile dep.
sayakpaul May 20, 2025
befdd9e
remove total gpu memory
sayakpaul May 20, 2025
4784b8b
fixes
sayakpaul May 20, 2025
c19dc5b
fix
sayakpaul May 20, 2025
2da4fac
need a big gpu
sayakpaul May 20, 2025
7367bb1
better
sayakpaul May 20, 2025
1cd472f
what's happening.
sayakpaul May 20, 2025
214795d
okay
sayakpaul May 20, 2025
7d4f459
Merge branch 'main' into benchmarking-overhaul
sayakpaul May 21, 2025
2d5b305
Merge branch 'main' into benchmarking-overhaul
sayakpaul May 22, 2025
dd42244
Merge branch 'main' into benchmarking-overhaul
sayakpaul May 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ env:
MKL_NUM_THREADS: 8

jobs:
torch_pipelines_cuda_benchmark_tests:
torch_models_cuda_benchmark_tests:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_BENCHMARK }}
name: Torch Core Pipelines CUDA Benchmarking Tests
name: Torch Core Models CUDA Benchmarking Tests
strategy:
fail-fast: false
max-parallel: 1
runs-on:
group: aws-g6-4xlarge-plus
group: aws-g6e-xlarge-plus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beefier machine.

container:
image: diffusers/diffusers-pytorch-cuda
options: --shm-size "16gb" --ipc host --gpus 0
Expand All @@ -37,8 +37,9 @@ jobs:
run: |
python -m venv /opt/venv && export PATH="/opt/venv/bin:$PATH"
python -m uv pip install -e [quality,test]
python -m uv pip install pandas peft
python -m uv pip uninstall transformers && python -m uv pip install transformers==4.48.0
python -m uv pip install pandas peft torchprofile
# Temporary.
pip install --force-reinstall https://github.com/bitsandbytes-foundation/bitsandbytes/releases/download/continuous-release_main/bitsandbytes-1.33.7.preview-py3-none-manylinux_2_24_x86_64.whl
- name: Environment
run: |
python utils/print_env.py
Expand All @@ -47,8 +48,8 @@ jobs:
HF_TOKEN: ${{ secrets.DIFFUSERS_BOT_TOKEN }}
BASE_PATH: benchmark_outputs
run: |
export TOTAL_GPU_MEMORY=$(python -c "import torch; print(torch.cuda.get_device_properties(0).total_memory / (1024**3))")
cd benchmarks && mkdir ${BASE_PATH} && python run_all.py && python push_results.py
cd benchmarks && python run_all.py && python push_results.py
mkdir ${BASE_PATH} && mv *.csv ${BASE_PATH}

- name: Test suite reports artifacts
if: ${{ always() }}
Expand Down
Empty file added benchmarks/__init__.py
Empty file.
346 changes: 0 additions & 346 deletions benchmarks/base_classes.py

This file was deleted.

Loading