Skip to content

[docs] Fix xDiT doc image damage #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

Eigensystem
Copy link
Contributor

What does this PR do?

Fixed xDiT document image damage

Before submitting

Who can review?

@stevhliu and @sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You could consider hosting this images in a dataset repository on the Hugging Face (perhaps through an org called xDiT) and use the links from there.

Here is an example of such a repository:
https://huggingface.co/datasets/huggingface/documentation-images

@Eigensystem
Copy link
Contributor Author

Great advice! I will try it. Thank you.

@Eigensystem Eigensystem changed the title [docs] Fix xDiT doc image damage [WIP] [docs] Fix xDiT doc image damage Oct 12, 2024
@Eigensystem Eigensystem changed the title [WIP] [docs] Fix xDiT doc image damage [docs] Fix xDiT doc image damage Oct 12, 2024
@sayakpaul sayakpaul merged commit 6a5f064 into huggingface:main Oct 12, 2024
1 check failed
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* docs: fix xDiT doc image damage

* doc: move xdit images to hf dataset

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants