Skip to content

Revert "[LoRA] fix: lora loading when using with a device_mapped mode… #9823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

yiyixuxu
Copy link
Collaborator

@yiyixuxu yiyixuxu commented Oct 31, 2024

…l. (#9449)"

This reverts commit 41e4779. becuse it broke the offloading for all model with shared checkpoint

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit d2e5cb3 into main Oct 31, 2024
16 of 18 checks passed
@yiyixuxu yiyixuxu deleted the revert branch October 31, 2024 18:19
a-r-r-o-w pushed a commit that referenced this pull request Nov 1, 2024
#9823)

Revert "[LoRA] fix: lora loading when using with a device_mapped model. (#9449)"

This reverts commit 41e4779.
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
#9823)

Revert "[LoRA] fix: lora loading when using with a device_mapped model. (#9449)"

This reverts commit 41e4779.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants