Skip to content

[internal] refacto tests for inference snippets #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 14, 2025

This PR does nothing else than updating packages/tasks-gen/scripts/generate-snippets-fixtures.ts which is an internal script used to test the inference snippets. Goal of this PR is to store generated snippet under a new file structure like this:

./snippets-fixtures/automatic-speech-recognition/python/huggingface_hub/1.hf-inference.py

instead of

./snippets-fixtures/automatic-speech-recognition/1.huggingface_hub.hf-inference.py

In practice the previous file naming was annoying as it meant that adding a new snippet in a client type could lead to renaming another file (due to the 0., 1., ... prefixes).


Typically in #1273 it makes the PR much bigger by e.g. deleting 1.openai.hf-inference.py and creating 2.openai.hf-inference.py just because a new 1.requests.hf-inference.py has been added.

Separating files by language + client avoid these unnecessary problems.

@Wauplin
Copy link
Contributor Author

Wauplin commented Mar 14, 2025

Merging as it's a purely internal change that could make #1273 and next PRs easier to review.

@Wauplin Wauplin merged commit c001002 into main Mar 14, 2025
5 checks passed
@Wauplin Wauplin deleted the inference-snippets-tests-new-structure branch March 14, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant