Skip to content

Add video-to-video #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add video-to-video #1469

wants to merge 4 commits into from

Conversation

merveenoyan
Copy link
Contributor

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @linoytsaban - since you wanted to open a PR for this!

@@ -111,6 +111,7 @@ export type {
} from "./zero-shot-object-detection/inference.js";

import type { ModelLibraryKey } from "../model-libraries.js";
import { get } from "http";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk where it came from lol thx for pointing out, fixed

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Do we have a list of models where this would already apply?

IIRC @linoytsaban had 10-12 models she was tracking!

@merveenoyan
Copy link
Contributor Author

@Vaibhavs10 this yields 62 models https://huggingface.co/search/full-text?q=video-to-video&type=model I'll open PRs

@@ -111,7 +111,6 @@ export type {
} from "./zero-shot-object-detection/inference.js";

import type { ModelLibraryKey } from "../model-libraries.js";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the blank line, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk it was linter :D

@@ -248,6 +248,7 @@ export const TASKS_DATA: Record<PipelineType, TaskData | undefined> = {
translation: getData("translation", translation),
"unconditional-image-generation": getData("unconditional-image-generation", unconditionalImageGeneration),
"video-text-to-text": getData("video-text-to-text", videoTextToText),
"video-to-video": getData("video-to-video", placeholder),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to come in a new PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess

@merveenoyan
Copy link
Contributor Author

@Vaibhavs10 I opened the PRs, we can merge when some are merged

@merveenoyan
Copy link
Contributor Author

merged main to this branch, it broke one test ^_^

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken test is unrelated to the PR, let's wait for more than half of PRs to be merged before merging this please.

Excited for this! 🤗

@sayakpaul
Copy link
Member

Cool work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants