Add more hw options #1498
Merged
Add more hw options #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KohakuBlueleaf
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
Vaibhavs10
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Thanks a lot! Looks good to me, let's wait for @pcuenca to take a look as well! 🔥
pcuenca
reviewed
Jun 4, 2025
packages/tasks/src/hardware.ts
Outdated
| @@ -278,7 +278,7 @@ export const SKUS = { | |||
| }, | |||
| "RTX 2080 Ti": { | |||
| tflops: 26.9, | |||
| memory: [11], | |||
| memory: [11, 22], //Modded 2080ti can be easily found in Taobao/Alibaba | |||
There was a problem hiding this comment.
lol, I'm not sure we should enter this rabbit hole, there are plenty of unofficial mods out there. Let's see how it goes cc @Vaibhavs10
pcuenca
reviewed
Jun 4, 2025
pcuenca
reviewed
Jun 4, 2025
pcuenca
reviewed
Jun 4, 2025
|
Failing test seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added some more hardware available in Hardware Settings:
The TFlops spec is from TechPowerUp