Skip to content

Fix to allow health check w/o auth #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kozistr
Copy link
Contributor

@kozistr kozistr commented Jul 26, 2024

What does this PR do?

Fixes #353

  • Separate the routers into two groups (one that requires auth and one that doesn't), and apply the auth middleware only for the group.

as-is (1.5.0)

$ curl -Is http://127.0.0.1:8081/health
HTTP/1.1 401 Unauthorized
content-length: 0
date: Fri, 26 Jul 2024 16:24:33 GMT
$ curl -Is http://127.0.0.1:8081/health -H 'Authorization: Bearer asdf'
HTTP/1.1 200 OK
content-length: 0
vary: origin, access-control-request-method, access-control-request-headers
access-control-allow-origin: *
date: Fri, 26 Jul 2024 16:24:41 GMT

to-be

$ curl -Is http://127.0.0.1:8080/health
HTTP/1.1 200 OK
content-length: 0
vary: origin, access-control-request-method, access-control-request-headers
access-control-allow-origin: *
date: Fri, 26 Jul 2024 16:24:52 GMT

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

Copy link
Contributor

@OlivierDehaene OlivierDehaene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OlivierDehaene OlivierDehaene merged commit ebe078a into huggingface:main Sep 17, 2024
@kozistr kozistr deleted the fix/allow-health-check-without-auth branch September 18, 2024 03:22
MasakiMu319 pushed a commit to MasakiMu319/text-embeddings-inference that referenced this pull request Nov 27, 2024
aagnone3 pushed a commit to StratisLLC/hf-text-embeddings-inference that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow http health check without authentication
2 participants