Skip to content

(FIX): CI Security Fix - branchname injection #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 29, 2025
Merged

(FIX): CI Security Fix - branchname injection #479

merged 9 commits into from
Jan 29, 2025

Conversation

glegendre01
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@glegendre01 glegendre01 marked this pull request as ready for review January 29, 2025 18:44
Narsil
Narsil previously approved these changes Jan 29, 2025
@Narsil Narsil merged commit f0e491a into main Jan 29, 2025
10 checks passed
@Narsil Narsil deleted the ci-security-fix branch January 29, 2025 21:04
@kaixuanliu
Copy link
Contributor

@glegendre01 Hi, I use latest code base to build docker image, it returns error " failed to solve: unexpected key 'env' in 'ENV=ACTIONS_CACHE_URL'". And if I delete env=ACTIONS_CACHE_URL and env=ACTIONS_RUNTIME_TOKEN in Dockerfile, it works ok. Can you tell me how to solve this in a better way?
The cmd line I used:
DOCKER_BUILDKIT=1 docker build --no-cache --build-arg PLATFORM="hpu" -f Dockerfile-intel -t tei_hpu .,
And the docker version is Docker version 25.0.3, build 4debf41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants