Enable splade embeddings for Python backend #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narsil
previously approved these changes
Mar 5, 2025
Signed-off-by: Daniel Huang <[email protected]>
pi314ever
force-pushed
the
splade-enabling
branch
from
3463b23 to
bb2093b
Compare
Signed-off-by: Daniel Huang <[email protected]>
|
@Narsil were there comments I missed before I rebased and resolved conflicts? They seem to have disappeared after my rebase. |
regisss
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
LGTM!
@pi314ever I think there was just a comment about merge conflicts, it's all good.
Narsil
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title says. Follows a modified version of huggingface#35.
Tested using local install and Intel docker on platform HPU using the README example for Splade usage.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.