Skip to content

fix bug for MaskedLanguageModel class` #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix bug for MaskedLanguageModel class` #513

merged 3 commits into from
Mar 17, 2025

Conversation

kaixuanliu
Copy link
Contributor

No description provided.

@kaixuanliu kaixuanliu marked this pull request as draft March 14, 2025 01:43
@kaixuanliu kaixuanliu marked this pull request as ready for review March 14, 2025 08:17
@kaixuanliu
Copy link
Contributor Author

When using models like sentence-transformers/all-mpnet-base-v2 to do embedding work, we should use AutoModel instead of AutoModelForMaskedLM to load the model , I made an adjustment in this PR, only when using splade pooling , we use AutoModelForMaskedLM. Pls help review, @regisss @Narsil

@kaixuanliu
Copy link
Contributor Author

cc @pi314ever

@pi314ever
Copy link
Contributor

Thanks @kaixuanliu for the fix. LGTM

regisss
regisss approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss
Copy link
Collaborator

regisss commented Mar 17, 2025

cc @Narsil

@regisss regisss merged commit c0b7080 into huggingface:main Mar 17, 2025
2 of 9 checks passed
@kaixuanliu kaixuanliu deleted the hpu-fix branch March 18, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi314ever pi314ever pi314ever approved these changes

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaixuanliu @pi314ever @regisss