Improve Ingestion for Web Documents #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alozowski
requested changes
May 28, 2025
yourbench/pipeline/ingestion.py
Outdated
| return None | ||
| except ImportError: | ||
| logger.error( | ||
| "Trafilatura library is not installed. Please install it (e.g., `pip install trafilatura`) " |
There was a problem hiding this comment.
Since trafilatura is now a hard dependency in pyproject.toml, we could probably remove the ImportError block. What do you think?
There was a problem hiding this comment.
yes! removed the import error block!
yourbench/pipeline/ingestion.py
Outdated
| file_ext = os.path.splitext(file_path)[1].lower() | ||
| content: str | None = None | ||
|
|
||
| if file_ext == ".md": |
There was a problem hiding this comment.
This section:
if file_ext == ".md":
...
elif file_ext in [".html", ".htm"]:
...
else:
...
This block is getting a bit long with the different file types. Maybe we could move it into a separate helper function? Something like get_markdown_content(file_path, markdown_processor) could make the main function easier to read and maintain – especially if we support more formats later
alozowski
approved these changes
Jun 4, 2025
Josephrp
pushed a commit
to Josephrp/yourbench
that referenced
this pull request
Jun 5, 2025
…-markitdown Improve Ingestion for Web Documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.