Integer overflow when parsing prefixed integers from qpack #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Overflow
previous to this PR the prefix_int
MAX_POWER
restricted to 10 * 7 (70) bits, which does not fit in an u64.This PR restricts the
MAX_POWER
to 9 * 7 (63) bits. This still meets the requirement from the qpack spec of 62 bit:This means our implementation now rejects some values that would fit in
u64
.Since the spec only requires 62 bit i chose this approach instead of adding more logic to the decoder.