implement generic key for no feature flag #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2022
seanmonstar
reviewed
Dec 8, 2022
| @@ -42,6 +43,8 @@ pub(super) trait Poolable: Unpin + Send + Sized + 'static { | |||
| fn can_share(&self) -> bool; | |||
| } | |||
|
|
|||
| pub trait Key: Eq + Hash + Clone + Debug + Unpin {} | |||
There was a problem hiding this comment.
Do we need the separate trait?
It looks like this may exist just to reduce the list at K: Eq + Hash + .... But if the trait doesn't provide anything new, it would provide a hurdle to users: they'd need to impl Key for MyThing. That'd be more annoying if MyThing were from a different crate, so they couldn't implement it.
There was a problem hiding this comment.
That's a great point, new to Rust things!!
There was a problem hiding this comment.
@seanmonstar we could do a blanket implementation? Or do you prefer putting all the individual traits on each bounds?
|
FYI: I moved this over to #16 since I don't have permission to push to this fork but am taking over the work. Apologies for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to make the client pooling
Keygeneric so that the caller can decide how they wish to pool the client connections.As of writing, it does not work with the
tokioruntime, I am relatively new to rust and was having some issues getting on of the futures functions to play nicely, would love so help.