Skip to content

chore: fix imports order across the repo #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

chore: fix imports order across the repo #8618

merged 1 commit into from
Jan 20, 2023

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Jan 19, 2023 •
edited
Loading

This is the command I ran at the root of the repo:

tree -f -P "*.go" -i | xargs gosimports -d -w -v -local "github.com/dgraph-io"  -

This required installing gosimports like this:

go install github.com/rinchsan/gosimports/cmd/gosimports@latest

@github-actions github-actions bot added area/bulk-loader Issues related to bulk loading. area/commercial area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/querylang Issues related to the query language specification and implementation. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues area/testing/jepsen labels Jan 19, 2023
@mangalaman93 mangalaman93 force-pushed the aman/imports branch 2 times, most recently from 760aad2 to 35ea7ff Compare January 19, 2023 13:34
sanjayk-github-dev
sanjayk-github-dev reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know what specific issue, if any, prompted this change or is this just implementing best practices?

@all-seeing-code
Copy link
Contributor

github.com/rinchsan/gosimports

This particular issue highlights problem with goimports: golang/go#20818

Mostly a syntactic issue.

@mangalaman93
Copy link
Member Author

Just best practices. I am also looking at other go vet issues and fixed some of those in #8620

sanjayk-github-dev
sanjayk-github-dev previously approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sanjayk-github-dev
sanjayk-github-dev approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for best practices

@mangalaman93 mangalaman93 merged commit cbec230 into main Jan 20, 2023
@mangalaman93 mangalaman93 deleted the aman/imports branch January 20, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@sanjayk-github-dev sanjayk-github-dev sanjayk-github-dev approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/bulk-loader Issues related to bulk loading. area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/querylang Issues related to the query language specification and implementation. area/schema Issues related to the schema language and capabilities. area/testing/jepsen area/testing Testing related issues
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mangalaman93 @all-seeing-code @sanjayk-github-dev