chore: Do not pin go patch level #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading golang/go#62278 (comment) I noticed that this is only recommended for development versions which are not released yet. This is no longer valid, by default the recommendation is to not use the patch level. If you need to pin to a explicit version, toolchain should be used since 1.21 instead, like `toolchain go1.24.3`. Setting just `go 1.24` will avoid failures if developers do not install the latest patch level yet, but allow the build to pick the most recent patch level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When reading golang/go#62278 (comment) I noticed that this is only recommended for development versions which are not released yet. This is no longer valid, by default the recommendation is to not use the patch level. If you need to pin to a explicit version, toolchain should be used since 1.21 instead, like
toolchain go1.24.3. Setting justgo 1.24will avoid failures if developers do not install the latest patch level yet, but allow the build to pick the most recent patch level.Go 1.24.3 should be picked up that way on rebuild
What
Remove patch level from go.mod
References
Checklist
unit/e2e test coverage added or updated?n/aNote: Remember to run a helm chart release after the the operator release to make the changes available thru helm.