Skip to content

False negatives for redundant jump rule #344

Open
@zaneduffield

Description

@zaneduffield

Prerequisites

  • This improvement has not already been suggested.
  • This improvement should not be implemented as a separate rule.

Rule to improve

RedundantJump

Improvement description

In the following example there are 2 redundant jumps that are not flagged by the current implementation of the rule

function Condition: Boolean;
begin
  Result := True;
end;

procedure Con;
begin
  for var I := 0 to 1 do begin
    if Condition then begin
      Continue; // not flagged
    end;
    Continue; // flagged
  end;
end;

procedure Brk;
begin
  for var I := 0 to 1 do begin
    if Condition then begin
      Break; // not flagged
    end;
    Break;
  end;
end;

Rationale

The rule should detect as many redundant jumps as possible, and this is another simple case to include.

Metadata

Metadata

Assignees

Labels

enhancementImprovements to an existing featureruleImprovements or additions to rules

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions