[SYCL] Add nested calls detection to shortcut functions #13659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
This reverts commit 57e0e33.
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@uditagarwal97 kindly ping |
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
hi @intel/llvm-gatekeepers, this PR is ready for merge, thanks |
aelovikov-intel
added a commit
that referenced
this pull request
Jun 6, 2025
1) Move `reduction::withAuxHandler` -> `HandlerAccess::postProcess`, as that's what it's really about. 2) Add comments describing what I see as issues with the previous/current implementation plus minor fixes of what I could address easily. 3) Added `HandlerAccess:preProcess` instead of using `addCounterInit` introduced in #13659. The original idea behind `withAuxHandler` and reduction implementations in general is to decouple them from SYCL RT internals as much as possible and `addCounterInit` was a step in the exact opposite direction. --------- Co-authored-by: Sergey Semenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original impl does not cover shortcut functions.
This version has thread_local global simple type variable that could track nested call within some queue functions like submit, memset, memcpy and others. Shortcut functions use common part submitMemOpHelper where detection is also added.
Reduction impl updated to eliminate nested call we did internally. It is even better since common logic with dependency tracking used in queue methods is not needed there.