[Driver][SYCL] Update default offload device settings with -fsycl #14208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with -fsycl, allow for default spir64 JIT device targets
to be built by default. This target will also be built along side any
AOT targets. For example:
clang++ -fsycl -c file.cpp // builds for spir64
clang++ -fsycl -fsycl-targets=intel_gpu_pvc // builds for spir64
// and spir64_gen pvc
Also introduces -fno-spirv for users who do not require the spir64
target to be generated. The use of -fno-spirv is default for
-fintelfpga usage.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
asudarsa
reviewed
Jun 19, 2024
| @@ -446,6 +446,12 @@ and not recommended to use in production environment. | |||
| When this option is used in conjunction with -fsycl, the driver will link | |||
| against an alternate form of libsycl, libsycl-preview. | |||
|
|
|||
| **`-fno-spirv`** | |||
There was a problem hiding this comment.
This description seems to be a bit misleading. It seems to suggest that users should use this option for all AOT target compilations. May be we can drop 'when targeting AOT devices'?
|
I do not think a review is required from me. But I was curious if this support is available on the new offloading side as well? Thanks |
@asudarsa, yes, this is available with the new offloading model. |
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with -fsycl, allow for default spir64 JIT device targets to be built by default. This target will also be built along side any AOT targets. For example:
clang++ -fsycl -c file.cpp // builds for spir64
clang++ -fsycl -fsycl-targets=intel_gpu_pvc // builds for spir64
// and spir64_gen pvc
Also introduces -fno-spirv for users who do not require the spir64 target to be generated. The use of -fno-spirv is default for -fintelfpga usage.