[SYCL] Implement device image properties for virtual functions #14875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
reviewed
Jul 31, 2024
llvm/test/tools/sycl-post-link/device-code-split/indirectly-callable.ll
Outdated
Show resolved
Hide resolved
llvm/test/tools/sycl-post-link/virtual-functions/module-cleanup-comdat.ll
Outdated
Show resolved
Hide resolved
llvm/test/tools/sycl-post-link/virtual-functions/module-cleanup.ll
Outdated
Show resolved
Hide resolved
…ual-functions-device-img-properties
AlexeySachkov
commented
Aug 2, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Aug 2, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…ual-functions-device-img-properties
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
AMD runner seems to be offline. Virtual function E2E tests are disabled on CUDA & HIP anyway and all builds completed, I do not expect any impact on AMD from this PR, so I will proceed with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation design explaining those changes in a bigger picture can be found in #10540
Key things implemented here:
calls-indirectlyLLVM IR attribute for kernels that construct objects with virtual functions, but don't do callsEven though those pieces are technically independent from each other, it is hard to split them apart into separate PRs, because they all have to be either present or absent for existing E2E tests for virtual functions to work.