[clang-linker-wrapper] Add error handling for missing linker path #15862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Sudarsanam <[email protected]>
asudarsa
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sarnex
reviewed
Oct 24, 2024
| @@ -411,6 +411,8 @@ Error runLinker(ArrayRef<StringRef> Files, const ArgList &Args) { | |||
| // Render the linker arguments and add the newly created image. We add it | |||
| // after the output file to ensure it is linked with the correct libraries. | |||
| StringRef LinkerPath = Args.getLastArgValue(OPT_linker_path_EQ); | |||
| if (LinkerPath.empty()) | |||
| return createStringError("Host linker is not available"); | |||
There was a problem hiding this comment.
Yes. Happening in parallel.
llvm/llvm-project#113613 (comment)
tests are different, but expect to converge after pulldown.
Thanks
sarnex
approved these changes
Oct 24, 2024
Signed-off-by: Arvind Sudarsanam <[email protected]>
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
approved these changes
Oct 24, 2024
asudarsa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In clang-linker-wrapper, we do not explicitly check if --linker-path is not provided.
This PR adds a check to capture this.
Thanks