Skip to content

[UR][L0] Implement support for device to device copy #16977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: sycl
Choose a base branch
from

Conversation

winstonzhang-intel
Copy link
Contributor

@winstonzhang-intel winstonzhang-intel commented Feb 11, 2025

Bindless Image: pitched usm image to pitched usm image copy.

@winstonzhang-intel winstonzhang-intel marked this pull request as ready for review February 20, 2025 17:15
@winstonzhang-intel winstonzhang-intel requested a review from a team as a code owner February 20, 2025 17:15
@DBDuncan
Copy link
Contributor

Would be good if you could look at enabling the device to device copy tests in sycl/test-e2e/bindless_images/copies. Have a look at removing // REQUIRES: cuda. You might need to add // UNSUPPORTED: target-amd to prevent failures on AMD.

Also, I am currently trying to get #16862 merged which will enable sycl/test-e2e/bindless_images/copies/device_to_device_copy_3D_subregion.cpp.

@winstonzhang-intel
Copy link
Contributor Author

Would be good if you could look at enabling the device to device copy tests in sycl/test-e2e/bindless_images/copies. Have a look at removing // REQUIRES: cuda. You might need to add // UNSUPPORTED: target-amd to prevent failures on AMD.

Also, I am currently trying to get #16862 merged which will enable sycl/test-e2e/bindless_images/copies/device_to_device_copy_3D_subregion.cpp.

I'll give that a try, thanks for the comment.

Copy link
Contributor

@ProGTX ProGTX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, what's the interaction with #17292, though? It seems like this PR should go in first.

Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
@winstonzhang-intel
Copy link
Contributor Author

As I have just tested, the changes that I've made are not the reason why these tests are failing. So now my question is, before we had copy from non-usm to non-usm memory, what were the tests that were conducted before?

Seems like these failures does not stem from my changes of pitched usm to pitched usm memory.

Signed-off-by: Zhang, Winston <[email protected]>
@JackAKirk
Copy link
Contributor

As I have just tested, the changes that I've made are not the reason why these tests are failing. So now my question is, before we had copy from non-usm to non-usm memory, what were the tests that were conducted before?

Seems like these failures does not stem from my changes of pitched usm to pitched usm memory.

Yeah my understanding is that these tests were always failing, you haven't broken them here, but you haven't fixed them either. You wrote above that you've enabled all tests for pitched usm. I pointed out that you've only enabled tests for 1d pitched usm, and that higher dimensional pitched USM is broken.
The PR title is "Implement support for device to device copies". I think it would make sense to fix them fully, since as I wrote above a complete fix is likely to interact with your partial fix here, so it is likely more efficient to fix everything at once.

Otherwise maybe you could e.g. update the desciption to "Bindless Image: 1D pitched usm image to pitched usm image copy."?

@winstonzhang-intel
Copy link
Contributor Author

Sounds good, this is more effort than originally projected. I will begin a triage effort on this to get multidimensional bindless copy enabled.

@JackAKirk
Copy link
Contributor

Sounds good, this is more effort than originally projected. I will begin a triage effort on this to get multidimensional bindless copy enabled.

OK sounds good.

@ProGTX
Copy link
Contributor

ProGTX commented May 21, 2025

@winstonzhang-intel what's the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants