-
Notifications
You must be signed in to change notification settings - Fork 768
[UR][L0] Implement support for device to device copy #16977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
4d4800a
to
5ff125d
Compare
3a3c3bd
to
bdea959
Compare
Would be good if you could look at enabling the device to device copy tests in Also, I am currently trying to get #16862 merged which will enable |
I'll give that a try, thanks for the comment. |
38460ee
to
b0bb050
Compare
b0bb050
to
0334165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, what's the interaction with #17292, though? It seems like this PR should go in first.
0334165
to
1ed025a
Compare
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
aa829ea
to
c3c5fa4
Compare
Signed-off-by: Zhang, Winston <[email protected]>
As I have just tested, the changes that I've made are not the reason why these tests are failing. So now my question is, before we had copy from non-usm to non-usm memory, what were the tests that were conducted before? Seems like these failures does not stem from my changes of pitched usm to pitched usm memory. |
cases Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Yeah my understanding is that these tests were always failing, you haven't broken them here, but you haven't fixed them either. You wrote above that you've enabled all tests for pitched usm. I pointed out that you've only enabled tests for 1d pitched usm, and that higher dimensional pitched USM is broken. Otherwise maybe you could e.g. update the desciption to "Bindless Image: 1D pitched usm image to pitched usm image copy."? |
Signed-off-by: Zhang, Winston <[email protected]>
Sounds good, this is more effort than originally projected. I will begin a triage effort on this to get multidimensional bindless copy enabled. |
OK sounds good. |
@winstonzhang-intel what's the status of this PR? |
Bindless Image: pitched usm image to pitched usm image copy.